Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Benjamin Drung [Tue, 27 Sep 2022 11:53:55 +0000 (13:53 +0200)]
Drop UBUNTU_MENUPROXY=0 workaround
wxWidgets 2.6 did not show menus correct on the global menu applet in
Unity in 2010 ([Ubuntu bug #662007](https://launchpad.net/bugs/662077)).
The environment variable `UBUNTU_MENUPROXY` was set as workaround.
Audacity 3.2.0 with wxWidgets 3.2 on Ubuntu 22.10 (kinetic) works fine
under the Unity desktop. Therefore drop the old workaround.
Forwarded: https://github.com/audacity/audacity/pull/3701 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Drop-UBUNTU_MENUPROXY-0-workaround.patch
Disable `EXPERIMENTAL_MIDI_OUT` in case MIDI support was explicitly
disabled.
Forwarded: https://github.com/audacity/audacity/pull/3717 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-setting-audacity_use_midi-off.patch
Benjamin Drung [Wed, 28 Sep 2022 13:20:05 +0000 (15:20 +0200)]
Add mime type for 'aup3' file extension
The new file extension `.aup3` is not recognized on Linux.
Add a new mime type `application/x-audacity-project+sqlite3` for the
file extension `.aup3` and add this mime type to the supported mime
types of audacity.
Ideally the Audacity team should register two mime types at IATA. These
mime type should probably be named `audio/vnd.audacity.project+sqlite3`
and `audio/vnd.audacity.project+xml`.
Forwarded: https://github.com/audacity/audacity/pull/3713 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Add-mime-type-for-aup3-file-extension.patch
Benjamin Drung [Thu, 22 Sep 2022 23:20:54 +0000 (01:20 +0200)]
Do not strip debug info for CMAKE_BUILD_TYPE=RelWithDebInfo
If `CMAKE_BUILD_TYPE` is set to `RelWithDebInfo` the debug information
should not be stripped. Currently `strip -x` is called when
`RelWithDebInfo` is set. A useless `echo` is called when `Debug` is set.
Skip `strip -x` when `CMAKE_BUILD_TYPE` is set to `Debug` or
`RelWithDebInfo`.
Forwarded: https://github.com/audacity/audacity/pull/3672 Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Do-not-strip-debug-info-for-CMAKE_BUILD_TYPE-RelWithDebIn.patch
Benjamin Drung [Thu, 22 Sep 2022 17:52:43 +0000 (19:52 +0200)]
Fix rpath for private libraries on Linux
Installing audacity on Linux will produce private libraries that have
`RUNPATH` set to the build directory instead of the installation
directory.
The root cause is that the library directory is copied to the
installation directory without touching the libraries. The cmake wiki
says in RPATH handling caveats [1]: "Since install-side RPATH tweaking
is an operation that is done by target-specific installation handling,
any target that should have its install RPATH changed (e.g. to
`CMAKE_INSTALL_RPATH`) needs to end up in the installation via an
`install(TARGETS ...)` signature and not via directory-based copying."
So replace `install(DIRECTORY ...)` by individual `install(TARGETS ...)`
for the libraries and modules. Then cmake will replace the `RUNPATH` to
`$ORIGIN/../lib/audacity`, which is still incorrect. Therefore set
`INSTALL_RPATH` explicitly.
Fixes: https://github.com/audacity/audacity/issues/3289
Forwarded: https://github.com/audacity/audacity/pull/3671
[1] https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/RPATH-handling#caveats Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
Gbp-Pq: Name Fix-rpath-for-private-libraries-on-Linux.patch
Dennis Braun [Wed, 26 May 2021 20:26:01 +0000 (22:26 +0200)]
audacity (2.4.2~dfsg0-5) unstable; urgency=medium
* Workaround patch for playback cursor under wayland
Audacity has no full wayland support yet, so we use X11 to start
(Closes: #950150, #962389, #988632, LP: #1877833)
The patch can probably be removed when wxwidgets 3.1.3 is in debian archive
* Add lintian-overrides to override false positive lintian errors
Workaround for a bug in wxWidgets 3.0 that causes the Fit()
function to fail in certain desktop environments (gnome, xfce)
before the first window of the same style class is shown on
screen (http://trac.wxwidgets.org/ticket/16440). As a workaround,
call Fit() and other methods that depend on its results again
*after* we know that the window has been shown. While the bug
may affect other calls to Fit() on a low level, the workaround
is necessary only for the recovery dialog, which is particularly
vulnerable because:
1. It is shown very, very early in the program execution and
therefore very likely to be the first dialog of its style class
shown on screen.
2. It doesn't have scrollbars or flexible-size controls that
could compensate the wrong dialog size.
Gbp-Pq: Name 0002-workaround-wxwidgets-fit-recovery.patch